Multiple applications push and pull API #15396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnsP
force-pushed
the
scm-multi-api
branch
4 times, most recently
from
eae55a2 to
bb42d83
Compare
GnsP
force-pushed
the
scm-multi-api
branch
2 times, most recently
from
cf2eb52 to
aaf1135
Compare
samdgupi
force-pushed
the
scm-multi-api
branch
7 times, most recently
from
a49969c to
26bedd5
Compare
samdgupi
changed the title
samdgupi
changed the title
samdgupi
force-pushed
the
scm-multi-api
branch
2 times, most recently
from
cc03fd1 to
5afbcc8
Compare
samdgupi
force-pushed
the
scm-multi-api
branch
2 times, most recently
from
d614228 to
ae99a92
Compare
albertshau
approved these changes
Nov 20, 2023
| try { | ||
| appsRequest = parseBody(request, PushMultipleAppsRequest.class); | ||
| } catch (JsonSyntaxException e) { | ||
| throw new BadRequestException("Invalid request body.", e); |
There was a problem hiding this comment.
In this particular case we want to include e.getMessage() in the error message, since that is what gets displayed to the user.
Note that this is not always what we want, especially for non-user facing exceptions, as that leads to duplicate logging.
| TransactionRunners.run(transactionRunner, context -> { | ||
| validateOnlyOneGitOperationRunning(namespace, context); | ||
| getOperationRunStore(context).createOperationRun(operationRunId, detail); | ||
| statePublisher.publishStarting(operationRunId); |
There was a problem hiding this comment.
note that it is possible to publish multiple starting messages if this transaction fails and is retried. Though I think the subscriber handles that case so it's not an issue.
There was a problem hiding this comment.
Yeah publishing multiple messages should not be an issue here as subscriber will effectively deduplicate it
samdgupi
force-pushed
the
operation-fixes
branch
2 times, most recently
from
4d4c682 to
888aa26
Compare
samdgupi
force-pushed
the
scm-multi-api
branch
from
ae99a92 to
a79a55c
Compare
samdgupi
force-pushed
the
scm-multi-api
branch
from
a79a55c to
a00f520
Compare
samdgupi
added a commit
that referenced
this pull request
Nov 22, 2023
[🍒] Add APIs to do multi pull/push from #15396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API endpoints for multiple applications push and pull.
Also restrict one multi operation at a time.